[Macros] Termination signal for executable plugin #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit the plugin when it receives an empty message. rdar://160820381
rintaro
requested review from
ahoppen,
bnbarham and
hamishknight
as code owners
Member
Author
|
swiftlang/swift#84829 |
rintaro
commented
Oct 10, 2025
| // Empty message is a termination signal. | ||
| if count == 0 { | ||
| return nil | ||
| } |
Member
Author
There was a problem hiding this comment.
FWIW, not returning nil is still safe. try _read(into: data) is no-op, and JSON.decode() would throw an Error, then the caller would exit(1). This change just make it graceful immediate exit(0)
Member
Author
|
swiftlang/swift#84829 |
2 similar comments
Member
Author
|
swiftlang/swift#84829 |
Member
Author
|
swiftlang/swift#84829 |
ahoppen
reviewed
Oct 11, 2025
|
|
||
| // Read the JSON payload. | ||
| let count = Int(UInt64(littleEndian: header)) | ||
| // Empty message is a termination signal. |
Member
There was a problem hiding this comment.
Is the compiler explicitly sending a message with header == 0 to indicate that the plugin process should exit?
Member
Author
There was a problem hiding this comment.
Yes, as being implemented in swiftlang/swift#84829
hamishknight
approved these changes
Oct 13, 2025
bnbarham
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit the plugin when it receives an empty message.
rdar://160820381