Introduce a severity level when recording issues #1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzannaratcliff
requested review from
stmontgomery,
grynspan,
briancroom and
SeanROlszewski
as code owners
stmontgomery
added
the
issue-handling
|
This is a good start. Please do add tests which call this new overload! |
|
@swift-ci please test |
stmontgomery
approved these changes
Apr 10, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a severity level when recording issues
Motivation:
In order to create issues that don't fail a test this introduces a parameter to specify the severity of the issue. This is in support of work added here for an issue severity: #931
This is experimental.
Example usage:
Issue.record("My comment", severity: .warning)Modifications:
I modified the
Issue.recordmethod signature to take in a severity level so that users can create issues that are not failing.Checklist: