Open
Conversation
Normally we try to _reduce_ our C++ content, but the complexity's much lower here since we can't use Swift's atomics properly on Darwin yet and since we don't need to juggle Swift module visibility.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
grynspan
added
performance
jerryjrchen
approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Empty file here is just to keep the compiler happy?
| FallbackEventHandler.cpp) | ||
| if("${CMAKE_CXX_COMPILER_FRONTEND_VARIANT}" STREQUAL "MSVC" OR | ||
| "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") | ||
| target_compile_options(_TestingInternals PRIVATE |
Contributor
There was a problem hiding this comment.
Is this supposed to be compile options for _TestingInterop instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normally we try to reduce our C++ content, but the complexity's much lower here since we can't use Swift's atomics properly on Darwin yet and since we don't need to juggle Swift module visibility.
Checklist: