-
Notifications
You must be signed in to change notification settings - Fork 102
Expand the 'Known Issues' documentation article #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the 'Known Issues' documentation article #823
Conversation
Resolves rdar://137961874
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
@@ -10,13 +10,135 @@ See https://swift.org/LICENSE.txt for license information | |||
See https://swift.org/CONTRIBUTORS.txt for Swift project authors | |||
--> | |||
|
|||
Highlight known issues when running tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this specific phrasing came from our DevPubs friends? So you might want to ask them to look too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've solicited feedback offline from @medreisbach @chuckdude @iamleeg
#expect(foodTruck.grill.isHeating) | ||
} | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add one more example showing all of the knobs and doodads in a single call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to decline to do this right now, mainly because the combinatorics make it difficult to have a coherent example. I could imagine offering more real-world examples in the future via some sort of example code repo/corpus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks only.
@swift-ci please test |
This expands the Known issues DocC article to give examples and describe several different ways it can be used.
Checklist:
Resolves rdar://137961874