inherit required protocols during TangentVector synthesis #34893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been running into a limitation with TangentVector synthesis. Here's a proposed solution and implementation.
The Problem
If you have a protocol
P
that refinesDifferentiable
and that constrains theTangentVector
to conform to something that can be derived, the compiler can't derive a conformance toP
.e.g.
Proposed Solution
When deriving the
TangentVector
, look at the conformance the triggered the derivation, find conformance constraints onTangentVector
implied by that conformance, and makeTangentVector
inherit the required protocols.One nice property of this solution is that it automatically figures out that
TangentVector
must conform toAdditiveArithmetic
andDifferentiable
, so these conformances no longer need to be hardcoded in the derivation.