Rewrite SimpleDidSetRequest to not require a typechecked body
#69215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
slavapestov
approved these changes
Oct 17, 2023
|
@swift-ci please smoke test macOS |
|
@swift-ci please clean smoke test macOS |
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
simpler-simple-did-set-request
branch
from
e37f2a0 to
6f338ad
Compare
|
@swift-ci please smoke test |
SimpleDidSetRequest's implementation was depending on type-checking the body of the observer, meaning that computing the interface type of a `didSet` would require type-checking the body first. This triggers some request cycles, and is unnecessarily complicated. Rewrite the implementation to work on a non-type-checked body, by using name lookup to establish when the `oldValue` parameter is referenced from the body.
`buildTypeRefinementContextHierarchyDelayed()` is already guarded behind a request, so it doesn't need its own logic for eliminating redundant computation. Remove that logic, which incorrectly assumed that the TRC was built for a function if the function body has already been parsed.
DougGregor
force-pushed
the
simpler-simple-did-set-request
branch
from
6f338ad to
df6d501
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleDidSetRequest's implementation was depending on type-checking the body of the observer, meaning that computing the interface type of a
didSetwould require type-checking the body first. This triggers some request cycles, and is unnecessarily complicated.Rewrite the implementation to work on a non-type-checked body, by using name lookup to establish when the
oldValueparameter is referenced from the body.