Fix missing diagnostics about the lack of initializers in cross-module inheritance scenarios #70219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases where a subclass was unable to synthesize any initializers (for example, because there were missing designated initializers in the superclass), we were skipping checking of superclass required initializers. This meant that we would silently accept subclasses that cannot be initialized directly (that would produce an error), but could at runtime be initialized via a required initializer... that didn't account for the subclass. Fixes the original problem from swiftlang#69965, but not the most minimal one.
…ssing ones The presence of a superclass from another module that has missing designated initializers was suppressing the diagnostic complaining about a class having no initializers. Start complaining about such classes when the superclass comes from Swift, but downgrade the error to a warning prior to Swift 6 so we don't break existing code. Fixes swiftlang#69965.
DougGregor
requested review from
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
|
Ah, it looks like we have a few other instances of this pattern in our test suite that I'll need to fix up. |
|
I'm splitting this into two different PRs. The most critical fix is the The second fix (of the "no constructors of class...") needs more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class inherits a superclass from another module, and that superclass has non-public designated initializers, two important diagnostics were being suppressed:
requiredinitializers in the superclass that couldn't be synthesized in the subclass, andBetween the two, it became possible to create a class that could not be initialized statically (doing so would produce an error), but that could be dynamically created via the required initializer---without initializing the subclass's storage. Introduce diagnostics for both, staging them in via warnings in Swift 5 and becoming errors in Swift 6.
Fixes #69965