[EXPERIMENTAL] Add Actor.runSynchronously() to synchronously wait for a closure to execute on an actor
#77749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecute on an actor The operation is executed at the given priority, and is in the same way as all other work on the actor. If the calling thread manages to take the actor lock, it will execute jobs up until this operation is completed, then return. Otherwise, it will block waiting for a different thread to execute this operation. This operation is only available for default actors (ones that do not have custom executors), and will trap if provided with an actor that has a custom executor. Note that the blocking nature of this operation makes it prone to deadlock, so it should be used sparingly.
|
@swift-ci please test |
ktoso
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Yeah that makes sense to enqueue a SynchronousWaitJob... Waiting impl is the simplest thing I had in mind, very curious if it'd work out well enough vs run loop involving tricks. If we were to do it for real it probably would be better without adding new param to enqueue() but checking job kind?
API discussion leaving out for later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation is executed at the given priority, and is in the same way as all other work on the actor. If the calling thread manages to take the actor lock, it will execute jobs up until this operation is completed, then return. Otherwise, it will block waiting for a different thread to execute this operation.
This operation is only available for default actors (ones that do not have custom executors), and will trap if provided with an actor that has a custom executor. Note that the blocking nature of this operation makes it prone to deadlock, so it should be used sparingly.