[6.1] SILGen: Fix verifier error when forming keypath to subscript with resilient index type #79323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilient index type emitKeyPathSubscriptOperands() uses the ArgEmitter to collect index arguments, which uses ResilienceExpansion::Minimal when lowering parameter types. For this reason, lowerKeyPathSubscriptIndexTypes() should also use ResilienceExpansion::Minimal when lowering parameter types. Otherwise, we crash in the SIL verifier due to a loadable vs address-only mismatch, if the index type is resilient. Fixes rdar://problem/144654366. Fixes swiftlang#79304.
|
@swift-ci Please test |
jckarter
approved these changes
Feb 12, 2025
hborla
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.1 cherry-pick of #79310
Description: Fixes a SIL verifier failure when forming a keypath with a subscript component where one of the parameters is a resilient value type.
Origination: The bug has always been there.
Scope of the issue: swift-testing started hitting the bug recently, which forced a revert of Introduce a severity level for issues, and a 'warning' severity swift-testing#931; they'd like a fix for 6.1.
Reviewed by: @jckarter
Risk: Low.
Radar: rdar://problem/144654366