Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ucrt.modulemap for Windows SDK 10.0.26100 #80144

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

Steelskin
Copy link
Contributor

@Steelskin Steelskin commented Mar 19, 2025

@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd compnerd added the 🍒 release cherry pick Flag: Release branch cherry picks label Mar 20, 2025
@Steelskin
Copy link
Contributor Author

For future reference, this is the failure:

C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\yams\Sources\Yams\Representer.swift:321:45: error: cannot find 'DBL_DECIMAL_DIG' in scope
319 |         // Since `NumberFormatter` creates a string with insufficient precision for Decode,
320 |         // it uses with `String(format:...)`
321 |         let string = String(format: "%.*g", DBL_DECIMAL_DIG, self)
    |                                             `- error: cannot find 'DBL_DECIMAL_DIG' in scope
322 |         // "%*.g" does not use scientific notation if the exponent is less than –4.
323 |         // So fallback to using `NumberFormatter` if string does not uses scientific notation.

@compnerd
Copy link
Member

@swift-ci please smoke test

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

2 similar comments
@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member

@swift-ci please smoke test Linux platform

@compnerd compnerd enabled auto-merge March 22, 2025 23:44
@shahmishal
Copy link
Member

@swift-ci test macOS

@shahmishal
Copy link
Member

@swift-ci test Linux

@compnerd compnerd merged commit 7bf11dc into swiftlang:release/6.1 Mar 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants