-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ucrt.modulemap for Windows SDK 10.0.26100 #80144
Merged
compnerd
merged 3 commits into
swiftlang:release/6.1
from
Steelskin:fabrice/cp-ucrt-modulemap
Mar 25, 2025
Merged
Update ucrt.modulemap for Windows SDK 10.0.26100 #80144
compnerd
merged 3 commits into
swiftlang:release/6.1
from
Steelskin:fabrice/cp-ucrt-modulemap
Mar 25, 2025
+28
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick from pull request swiftlang#79751
compnerd
approved these changes
Mar 20, 2025
@swift-ci please smoke test |
For future reference, this is the failure:
|
@swift-ci please smoke test |
@swift-ci please smoke test Linux platform |
2 similar comments
@swift-ci please smoke test Linux platform |
@swift-ci please smoke test Linux platform |
@swift-ci test macOS |
@swift-ci test Linux |
shahmishal
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows SDK 10.0.26100 added an include to compiler intrinsics headers in
wchar.h
. In turn, these headers includemalloc.h
,stdlib.h
andstddef.h
fromucrt
, this leads to a cyclic dependency between theucrt
and compiler intrinsics modules. Furthermore, Clang 19 (from Swift 6.1) intrinsics headers sometimes clash with the ucrt headers dependencies.These changes separate the problematic headers into different standalone modules.
The changes are limited to
ucrt.modulemap
, and should be backward-compatible with older Windows SDK versions.Update ucrt.modulemap for Windows SDK 10.0.26100 #79751
Restore legacy_stdio_definitions in ucrt.modulemap #80151
Put float and stddef back inside the ucrt module #80200
Very low.
Local testing with simple projects including the
ucrt
module with the new module map.@compnerd