Serialization: Skip invalid @available attributes during lazy serialization
#80215
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization. When performing lazy module serialization, we may be making the first attempt to turn an `AvailableAttr` into a `SemanticAvailableAttr`. If it turns out the attribute is invalid at that point, we need to skip it instead of assuming that the attribute will always be valid there. Resolves rdar://147539902.
|
@swift-ci please smoke test |
xymus
approved these changes
Mar 21, 2025
|
@swift-ci please smoke test macOS |
1 similar comment
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing lazy module serialization, we may be making the first attempt to turn an
AvailableAttrinto aSemanticAvailableAttr. If it turns out the attribute is invalid at that point, we need to skip it instead of assuming that the attribute will always be valid there.Resolves rdar://147539902.