[StdlibUnittest] add a TestRunPredicate for WASI #80217
Merged
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly skip `expectCrashLater()` tests for WASI, instead of conditionally excluding them from compilation. In doing so, restored some tests that were wrongly excluded from the WASI tests suite.
|
@swift-ci please test Linux platform |
|
@swift-ci please smoke test Windows platform |
|
@swift-ci please test Linux platform |
kateinoigakukun
approved these changes
Mar 22, 2025
|
@swift-ci please smoke test macOS platform |
MaxDesiatov
approved these changes
Mar 22, 2025
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests are conditionally excluded from compilation on WASI, and this is error-prone. Tests should instead be explicitly skipped in each case. By doing this on only one file, several wrongly-excluded test cases are restored to the WASI test suite.