-
Notifications
You must be signed in to change notification settings - Fork 10.6k
update-checkout: bump libcurl to 8.17.0 #86321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-checkout: bump libcurl to 8.17.0 #86321
Conversation
|
CC: @etcwilde |
|
@swift-ci please test |
|
What's up with this wasm build error on Linux I wonder? |
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows should be done at the same time; the libxml2 update is invalid - that breaks ABI and is not compatible with Foundation. I could not get Foundation to work with the new ABI as the behaviour of some of the parsing changed, see swiftlang/swift-corelibs-foundation#5082 for some of the initial work to support that.
I'm confused — we are building libxml2 from source and only linking to it from FoundationXML. Why is ABI compatibility a concern? Do you mean that the API changed in some incompatible way? If so, then that is indeed a problem, but one that we will need to address eventually if we ever want to move forward with libxml2 updates (and the attendant security fixes). Regardless, I don't think that is the source of the error I cited, which is a build failure with libxml2 itself. In any case, this might be a bigger task than I had anticipated, so perhaps I should split up the libcurl and libxml2 updates into two separate PRs (especially since I am mostly interested in the libcurl upgrade for the SSDK4A)… |
|
The semantics of the API have changed, not the shape of the API. So while source compatible (i.e. the code will build), it behaves differently. I was clumping it under ABI compatibility, but, yes, it could be deemed an API break. Splitting up the updates makes sense to me - and is generally better IMO. |
|
OK, scaling back my ambitions and making this jump bump libcurl. @swift-ci please test |
|
The libcurl version seems to no longer be hardcoded in Lines 2646 to 2649 in 0709a78
|
compnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, updating update-checkout-config.json should update the version that Windows uses to build as well.
|
@swift-ci please test macOS platform |
|
CC: @swiftlang/android-workgroup (as mentioned at the meeting today) |
|
Merging since this version is only used on Windows and the Android SDK, for which all the relevant parties have signed off, whereas the static linux SDK downloads curl separately. |
Following on from a discussion at swiftlang/swift-docker#488 (comment), this PR updates the following dependencies for
main,6.3,next, andrebranch:libxml2 from 2.11.5 (Feb 4, 2024) to 2.15.1 (Oct 16, 2025)Given that both of these libraries process untrusted input, keeping up with the latest releases is probably a good idea.
libxml2, in particular, has had some serious CVEs addressed since 8.9.1.@compnerd, you did the last bump in #75717 and #75868, where you did Windows at the same time. Should I tack the Windows update onto this PR or do it separately?