Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a global variable cpuArch #216

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a global variable cpuArch #216

wants to merge 3 commits into from

Conversation

danny1113
Copy link

  • Move arch string literal to a global variable cpuArch.
  • Refactor: Let compiler to infer the array type.

@cmcgee1024
Copy link
Member

Thanks @danny1113

This is a good clean up of some ugly code. I'm going to run the tests on this, but will need to wait a bit longer to merge it since we're trying to close off the 0.4.0 release leaving the branch open for last minute stability fixes.

@cmcgee1024
Copy link
Member

@danny1113 can you reformat the new code following the instructions in the failed workflow here: https://github.com/swiftlang/swiftly/actions/runs/13129413293/job/36656660591?pr=216

@cmcgee1024
Copy link
Member

@swift-ci test macOS

cmcgee1024
cmcgee1024 reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@cmcgee1024 cmcgee1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me and the checks are all passing. I'm not approving and merging it for now since there is a freeze on the main branch.

@danny1113
Copy link
Author

This all looks good to me and the checks are all passing. I'm not approving and merging it for now since there is a freeze on the main branch.

Got it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcgee1024 cmcgee1024 cmcgee1024 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danny1113 @cmcgee1024