Update documentation and online help around global default toolchains #224
+54
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…obal default and in-use toolchains Skip prompting to update an existing swift version file Add more informative messages when using toolchains to indicate what actually changed
|
@swift-ci test macOS |
|
|
||
| if case let .swiftVersionFile(versionFile, _, _) = result { | ||
| // We don't care in this case if there were any problems with the swift version files, just overwrite it with the new value |
There was a problem hiding this comment.
Do we still want to respect assumeYes here and if not, prompt the user?
There was a problem hiding this comment.
The feedback I've received is that because we're updating an existing file, not creating a new one, and the file is very simple it should be ok to continue without a prompt/assume-yes as long as we provide a clear message of what has happened.
The file `path/to/.swift-version` has been set to `6.0.3` (was 6.0.1)
With this information, one can reverse what has happened.
There is still a prompt and assume-yes in the case where a new file is created because it helps with discovering the feature, and happens less regularly.
justice-adams-apple
approved these changes
Feb 11, 2025
patrickfreed
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip prompting to update an existing swift version file
Add more informative messages when using toolchains to indicate what actually changed