Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSValueDecoder #185

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Fix JSValueDecoder #185

merged 2 commits into from
Apr 9, 2022

Conversation

j-f1
Copy link
Member

@j-f1 j-f1 commented Apr 9, 2022

We didn’t have any tests exercising this code, and as far as I can tell it has never worked.

@j-f1 j-f1 requested a review from a team April 9, 2022 16:23
@github-actions
Copy link

github-actions bot commented Apr 9, 2022

Time Change: +603.25ms (6%) 🔍

Total Time: 9,693.75ms

Test name Duration Change
Serialization/Swift Int to JavaScript 2,912.75ms +184.5ms (6%) 🔍
Serialization/Swift String to JavaScript 2,978ms +177ms (5%) 🔍
Object heap/Increment and decrement RC 3,366.5ms +241ms (7%) 🔍
ℹ️ View Unchanged
Test name Duration Change
Serialization/Write JavaScript number directly 214.5ms -3ms (1%)
Serialization/Write JavaScript string directly 222ms +3.75ms (1%)

performance-action

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Didn't we have an open issue for this somewhere, or am I misremembering?

@j-f1
Copy link
Member Author

j-f1 commented Apr 9, 2022

Not that I know of, although there is #116 for implementing JSValueEncoder.

@j-f1 j-f1 merged commit 7b0e0d2 into main Apr 9, 2022
@j-f1 j-f1 deleted the jed/fix-jsvaluedecoder branch April 9, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants