Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround Swift 6.0 compiler crash #293

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 13, 2025

Copy link

Time Change: +63ms (0%)

Total Time: 9,790ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 23ms -3ms (13%) 👏
Serialization/JavaScript function call through Wasm import with int 21ms -2ms (9%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call from Swift 126ms -0ms
Serialization/Swift Int to JavaScript with assignment 348ms -8ms (2%)
Serialization/Swift Int to JavaScript with call 971ms -43ms (4%)
Serialization/JavaScript Number to Swift Int 283ms -9ms (3%)
Serialization/Swift String to JavaScript with assignment 441ms +8ms (1%)
Serialization/Swift String to JavaScript with call 1,076ms -20ms (1%)
Serialization/JavaScript String to Swift String 3,733ms +144ms (3%)
Object heap/Increment and decrement RC 2,755ms -5ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 3ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 13, 2025 04:51
@kateinoigakukun kateinoigakukun merged commit 2cd0a2c into main Mar 13, 2025
7 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/fix-compiler-crash-6.0.3 branch March 13, 2025 04:51
@gregcotten gregcotten mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant