Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom test framework #295

Merged
merged 6 commits into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ jobs:
- name: Configure Swift SDK
run: echo "SWIFT_SDK_ID=${{ steps.setup-swiftwasm.outputs.swift-sdk-id }}" >> $GITHUB_ENV
- run: make bootstrap
- run: make test
- run: make unittest
# Skip unit tests with uwasi because its proc_exit throws
# unhandled promise rejection.
Expand Down
12 changes: 4 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,10 @@ Thank you for considering contributing to JavaScriptKit! We welcome contribution
```

### Running Tests
- Run unit tests:
```bash
make unittest SWIFT_SDK_ID=wasm32-unknown-wasi
```
- Run integration tests:
```bash
make test SWIFT_SDK_ID=wasm32-unknown-wasi
```

```bash
make unittest SWIFT_SDK_ID=wasm32-unknown-wasi
```

### Editing `./Runtime` directory

Expand Down
17 changes: 0 additions & 17 deletions IntegrationTests/TestSuites/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -11,30 +11,13 @@ let package = Package(
.macOS("12.0"),
],
products: [
.executable(
name: "PrimaryTests", targets: ["PrimaryTests"]
),
.executable(
name: "ConcurrencyTests", targets: ["ConcurrencyTests"]
),
.executable(
name: "BenchmarkTests", targets: ["BenchmarkTests"]
),
],
dependencies: [.package(name: "JavaScriptKit", path: "../../")],
targets: [
.target(name: "CHelpers"),
.executableTarget(name: "PrimaryTests", dependencies: [
.product(name: "JavaScriptBigIntSupport", package: "JavaScriptKit"),
"JavaScriptKit",
"CHelpers",
]),
.executableTarget(
name: "ConcurrencyTests",
dependencies: [
.product(name: "JavaScriptEventLoop", package: "JavaScriptKit"),
]
),
.executableTarget(name: "BenchmarkTests", dependencies: ["JavaScriptKit", "CHelpers"]),
]
)

This file was deleted.

Loading