Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageToJS: Emit hints for permission denied errors #305

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

kateinoigakukun
Copy link
Member

No description provided.

@kateinoigakukun kateinoigakukun force-pushed the yt/add-more-didyoumean branch from a6d763f to c4bcdc6 Compare March 18, 2025 04:19
Copy link

github-actions bot commented Mar 18, 2025

Time Change: +165ms (1%)

Total Time: 9,754ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 23ms +1ms (5%) 🔍
Serialization/JavaScript function call from Swift 128ms +7ms (5%) 🔍
Serialization/Swift Int to JavaScript with assignment 351ms +21ms (5%) 🔍
Serialization/Swift String to JavaScript with assignment 453ms +36ms (7%) 🔍
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 24ms +0ms
Serialization/Swift Int to JavaScript with call 988ms +23ms (2%)
Serialization/JavaScript Number to Swift Int 283ms +11ms (3%)
Serialization/Swift String to JavaScript with call 1,076ms +36ms (3%)
Serialization/JavaScript String to Swift String 3,639ms +47ms (1%)
Object heap/Increment and decrement RC 2,774ms -18ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 3ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 4ms
Serialization/Call with JavaScript string directly 3ms

@kateinoigakukun kateinoigakukun force-pushed the yt/add-more-didyoumean branch 2 times, most recently from 955e2ed to 2e3fb62 Compare March 18, 2025 04:27
@kateinoigakukun kateinoigakukun force-pushed the yt/add-more-didyoumean branch from 2e3fb62 to f12b41a Compare March 18, 2025 04:39
@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 18, 2025 04:42
@kateinoigakukun kateinoigakukun merged commit a37dfa9 into main Mar 18, 2025
5 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/add-more-didyoumean branch March 18, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant