Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSObject.id getter inlinable #306

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Make JSObject.id getter inlinable #306

merged 1 commit into from
Mar 18, 2025

Conversation

kateinoigakukun
Copy link
Member

This change makes JSObject.id getter inlinable. Those who use the API to avoid dynamic member lookup overhead can now benefit from the inlinable getter.

This change makes `JSObject.id` getter inlinable. Those who use the API
to avoid dynamic member lookup overhead can now benefit from the
inlinable getter.
Copy link

Time Change: -51ms (0%)

Total Time: 9,559ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 22ms -2ms (7%)
View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import with int 20ms +1ms
Serialization/JavaScript function call from Swift 123ms -2ms (1%)
Serialization/Swift Int to JavaScript with assignment 330ms -5ms (1%)
Serialization/Swift Int to JavaScript with call 964ms -5ms (0%)
Serialization/JavaScript Number to Swift Int 271ms +2ms (0%)
Serialization/Swift String to JavaScript with assignment 411ms -0ms
Serialization/Swift String to JavaScript with call 1,034ms -10ms (0%)
Serialization/JavaScript String to Swift String 3,592ms -24ms (0%)
Object heap/Increment and decrement RC 2,777ms -6ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 3ms
Serialization/Assign JavaScript number directly 2ms
Serialization/Call with JavaScript number directly 3ms
Serialization/Write JavaScript string directly 4ms
Serialization/Call with JavaScript string directly 3ms

Copy link
Contributor

@fjtrujy fjtrujy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 18, 2025 08:25
@kateinoigakukun kateinoigakukun merged commit e36e93c into main Mar 18, 2025
5 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/inline-id branch March 18, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants