Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock JSTypedArray for Embedded Swift #317

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

kateinoigakukun
Copy link
Member

@kateinoigakukun kateinoigakukun commented Mar 27, 2025

API Change

  • JSTypedArray is now a final class so that to be Embedded friendly
  • JSUInt8ClampedArray no longer inherits JSTypedArray but now is aliased as JSTypedArray<JSUInt8Clamped>

@kateinoigakukun kateinoigakukun force-pushed the katei/embedded-typed-array branch from 9dbab78 to f41f234 Compare March 27, 2025 09:26
Copy link

github-actions bot commented Mar 27, 2025

Time Change: +93ms (0%)

Total Time: 9,917ms

View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 24ms -0ms
Serialization/JavaScript function call through Wasm import with int 23ms -1ms
Serialization/JavaScript function call from Swift 129ms -5ms (3%)
Serialization/Swift Int to JavaScript with assignment 335ms +2ms (0%)
Serialization/Swift Int to JavaScript with call 984ms -5ms (0%)
Serialization/JavaScript Number to Swift Int 263ms +1ms
Serialization/Swift String to JavaScript with assignment 413ms -0ms
Serialization/Swift String to JavaScript with call 1,080ms +18ms (1%)
Serialization/JavaScript String to Swift String 3,722ms +48ms (1%)
Object heap/Increment and decrement RC 2,909ms +33ms (1%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 10ms
Serialization/Assign JavaScript number directly 8ms
Serialization/Call with JavaScript number directly 5ms
Serialization/Write JavaScript string directly 7ms
Serialization/Call with JavaScript string directly 6ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 27, 2025 09:58
@kateinoigakukun kateinoigakukun merged commit 9b48693 into main Mar 27, 2025
6 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/embedded-typed-array branch March 27, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant