Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node version diagnostic handling on test harness #328

Merged
merged 1 commit into from
Apr 1, 2025

Conversation

kateinoigakukun
Copy link
Member

The CompileError usually happens during defaultNodeSetup, so we should catch it there. Also process.version is a string with a v prefix, so we should use process.versions.node, which doesn't have the prefix instead.

The CompileError usually happens during `defaultNodeSetup`, so we
should catch it there. Also `process.version` is a string with a `v`
prefix, so we should use `process.versions.node`, which doesn't have
the prefix instead.
@kateinoigakukun kateinoigakukun marked this pull request as ready for review March 31, 2025 23:53
Copy link

Time Change: -11ms (0%)

Total Time: 9,947ms

View Unchanged
Test name Duration Change
Serialization/JavaScript function call through Wasm import 25ms +0ms
Serialization/JavaScript function call through Wasm import with int 23ms +0ms
Serialization/JavaScript function call from Swift 130ms +2ms (1%)
Serialization/Swift Int to JavaScript with assignment 330ms +0ms
Serialization/Swift Int to JavaScript with call 993ms +3ms (0%)
Serialization/JavaScript Number to Swift Int 271ms +4ms (1%)
Serialization/Swift String to JavaScript with assignment 414ms +1ms
Serialization/Swift String to JavaScript with call 1,071ms +3ms (0%)
Serialization/JavaScript String to Swift String 3,815ms -23ms (0%)
Object heap/Increment and decrement RC 2,840ms -2ms (0%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 9ms
Serialization/Assign JavaScript number directly 8ms
Serialization/Call with JavaScript number directly 9ms
Serialization/Write JavaScript string directly 5ms
Serialization/Call with JavaScript string directly 5ms

@kateinoigakukun kateinoigakukun merged commit bad9706 into main Apr 1, 2025
6 checks passed
@kateinoigakukun kateinoigakukun deleted the katei/fix-node-version-hint branch April 1, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant