Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix native build for missing symbol #329

Merged
merged 2 commits into from
Apr 1, 2025
Merged

Conversation

kateinoigakukun
Copy link
Member

No description provided.

```
$s13JavaScriptKit8JSObjectC2idACs6UInt32V_tcfc: error: undefined reference to 'swjs_get_worker_thread_id_cached'
```
Copy link

github-actions bot commented Apr 1, 2025

Time Change: +467ms (4%)

Total Time: 10,027ms

Test name Duration Change
Serialization/JavaScript function call through Wasm import 25ms +2ms (8%) 🔍
Serialization/JavaScript function call through Wasm import with int 23ms +2ms (7%) 🔍
Serialization/JavaScript function call from Swift 136ms +11ms (8%) 🔍
Serialization/Swift Int to JavaScript with assignment 345ms +23ms (6%) 🔍
Serialization/JavaScript Number to Swift Int 280ms +18ms (6%) 🔍
Serialization/JavaScript String to Swift String 3,795ms +227ms (5%) 🔍
View Unchanged
Test name Duration Change
Serialization/Swift Int to JavaScript with call 1,005ms +44ms (4%)
Serialization/Swift String to JavaScript with assignment 419ms +8ms (1%)
Serialization/Swift String to JavaScript with call 1,090ms +44ms (3%)
Object heap/Increment and decrement RC 2,879ms +91ms (3%)
View Baselines
Test name Duration
Serialization/Call JavaScript function directly 7ms
Serialization/Assign JavaScript number directly 7ms
Serialization/Call with JavaScript number directly 5ms
Serialization/Write JavaScript string directly 7ms
Serialization/Call with JavaScript string directly 5ms

@kateinoigakukun kateinoigakukun marked this pull request as ready for review April 1, 2025 13:52
@kateinoigakukun kateinoigakukun merged commit f4d5219 into main Apr 1, 2025
6 checks passed
@kateinoigakukun kateinoigakukun deleted the yt/fix-xcode-build branch April 1, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant