Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs and cleanup #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add specs and cleanup #1

wants to merge 5 commits into from

Conversation

toppsdown
Copy link

@peakxu @tlunter

This PR covers the two proposed approaches for handling dynamo local

  1. Test connection to local dynamo(with retries) before proceeding
  2. Guarantee cleanup of processes

Open questions:
@peakxu I'm not sure how to test the at_exit via RSpec, though I have validated on my machine. It appears that the at_exit doesn't run until after all of the specs have finished and the way I currently have them set up is that each test starts a new process, runs test, then cleans up without the at_exit.

@tlunter As you mentioned, we need to get this added to our CI system, we can discuss tomorrow

@peakxu
Copy link

peakxu commented Oct 5, 2015

@toppy42, regarding at_exit testing. I think it's a low enough level concern that it's not worth testing directly within rspec. Having coverage for the teardown method is enough. I think we can trust that the Ruby internals for the simple delegation works as expected.

Perhaps there's something I'm missing but I do not see the need to check in all the Jar dependencies into source control. Let's discuss?

@tlunter
Copy link

tlunter commented Oct 5, 2015

@toppy42 we should use travis on this. Sync up after lunch?

@peakxu
Copy link

peakxu commented Oct 7, 2015

@toppy42, despite my usual reservations to commit binaries to source control, I think the payloads are small enough that it's not a big deal this time. Let's just go forward w/ this for now. :shipit:

Preferred longer term solution is a mirror on a CDN type site with explicit versioning (actual Jar version if we can, SHA1 if not) for reproducible builds. That way, we don't need full binaries in source control.

@toppsdown toppsdown force-pushed the add_specs_and_cleanup branch from 44cccef to 050ec13 Compare October 15, 2015 15:22
@mihado
Copy link

mihado commented Oct 23, 2015

@peakxu @toppy42 have you guys consider https://git-lfs.github.com/ for versioning these jars?

@peakxu
Copy link

peakxu commented Oct 23, 2015

@MEKF, was unaware of that. Thanks for the pointer. Will definitely check that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants