-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specs and cleanup #1
base: master
Are you sure you want to change the base?
Conversation
@toppy42, regarding Perhaps there's something I'm missing but I do not see the need to check in all the Jar dependencies into source control. Let's discuss? |
@toppy42 we should use travis on this. Sync up after lunch? |
@toppy42, despite my usual reservations to commit binaries to source control, I think the payloads are small enough that it's not a big deal this time. Let's just go forward w/ this for now. Preferred longer term solution is a mirror on a CDN type site with explicit versioning (actual Jar version if we can, SHA1 if not) for reproducible builds. That way, we don't need full binaries in source control. |
44cccef
to
050ec13
Compare
@peakxu @toppy42 have you guys consider https://git-lfs.github.com/ for versioning these jars? |
@MEKF, was unaware of that. Thanks for the pointer. Will definitely check that out. |
@peakxu @tlunter
This PR covers the two proposed approaches for handling dynamo local
Open questions:
@peakxu I'm not sure how to test the at_exit via RSpec, though I have validated on my machine. It appears that the at_exit doesn't run until after all of the specs have finished and the way I currently have them set up is that each test starts a new process, runs test, then cleans up without the at_exit.
@tlunter As you mentioned, we need to get this added to our CI system, we can discuss tomorrow