Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Health Check Endpoint #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matthewdfuller
Copy link
Contributor

This PR adds a simple health check to the service which can be accessed at /healthcheck. This allows for services like Marathon to assess the health of the container.

@nahiluhmot
Copy link
Contributor

@matthewdfuller Thanks for the contribution!

This looks good, but could you please combine your new conditional and the existing conditional with an else if?

@matthewdfuller
Copy link
Contributor Author

Sure thing @nahiluhmot - should be fixed now

@matthewdfuller
Copy link
Contributor Author

@nahiluhmot - can we merge this in?

@nahiluhmot
Copy link
Contributor

Hey, sorry about that. We can merge!

@nahiluhmot
Copy link
Contributor

... after a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants