Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby's Rainbow Project #197

Merged
merged 7 commits into from
Aug 13, 2024
Merged

Add Ruby's Rainbow Project #197

merged 7 commits into from
Aug 13, 2024

Conversation

andresclua
Copy link
Contributor

Description

Add Project https://rubysrainbow.org/ to showcase

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

Additional information

Copy link

netlify bot commented Jul 30, 2024

Deploy Preview for splendorous-kataifi-9ae281 ready!

Name Link
🔨 Latest commit 861ba36
🔍 Latest deploy log https://app.netlify.com/sites/splendorous-kataifi-9ae281/deploys/66bb46be2964400008e18814
😎 Deploy Preview https://deploy-preview-197--splendorous-kataifi-9ae281.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andresclua
Copy link
Contributor Author

hey @daun is it expected to add this project to showcase in the near future?

@daun
Copy link
Member

daun commented Aug 9, 2024

@andresclua Sure. Just other stuff to do as well :)

@daun
Copy link
Member

daun commented Aug 9, 2024

@andresclua Could you please reupload the screenshot as a png file? Looks like we hardcoded the screenshot filenames to png to avoid jpeg compression artefacts.

@andresclua
Copy link
Contributor Author

rubysrainbow

let me know if that works @daun

@daun
Copy link
Member

daun commented Aug 9, 2024

@andresclua Looks good, but can you push it to the branch so I can merge it? I don't have access to a dev environment at the moment.

Add ruby's rainbow image for showcase
@daun
Copy link
Member

daun commented Aug 9, 2024

@andresclua Can you please convert the image to an actual png file instead of just changing the file extension, and then push the png and delete the jpeg? Thanks!

@daun
Copy link
Member

daun commented Aug 13, 2024

I've converted the file to png format. Should be live in a few minutes 🤹‍♂️

@daun daun merged commit dd94dab into swup:master Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants