Skip to content

Add #[NoDiscard] to the PHP 8.5 polyfill #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Conversation

schodemeiss
Copy link

No description provided.

Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schodemeiss
Copy link
Author

schodemeiss commented Apr 7, 2025

Thanks, the stub is identical to the one provided in php-src: https://github.com/TimWolla/php-src/blob/d80682e753af13a89ad71ee78100ce44045f175d/Zend/zend_attributes.stub.php#L88-L97

Indeed. I presumed that was the correct thing to do.

Do we know when this Polyfill will be published as non-dev. I noticed it's on Packagist, but not as 1.38 (or whatever the other polyfills are).

https://packagist.org/packages/symfony/polyfill-php85

@fabpot
Copy link
Member

fabpot commented May 2, 2025

Thank you @schodemeiss.

@fabpot fabpot merged commit a494f75 into symfony:1.x May 2, 2025
1 of 10 checks passed
@schodemeiss
Copy link
Author

Thank you @schodemeiss.

You're welcome. When do the polyfill packages get officially published? I noticed that whilst php85 appears on Packagist, it's still on the dev branch.

@fabpot
Copy link
Member

fabpot commented May 2, 2025

Thank you @schodemeiss.

You're welcome. When do the polyfill packages get officially published? I noticed that whilst php85 appears on Packagist, it's still on the dev branch.

I've released v1.32.0 which includes the PHP 8.5 polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants