Add return types to fixtures

Author: derrabus

.github/workflows/ci.yml

@@ -19,6 +19,7 @@ jobs:
                       deprecations: max[self]=0
                     - php: '8.0'
                       deps: highest
+                      deprecations: max[indirect]=5
 
         steps:
             - name: Checkout code

Tests/Fixtures/Message.php

@@ -29,63 +29,88 @@ public function __construct($version = '1.1', array $headers = [], StreamInterfa
     {
         $this->version = $version;
         $this->headers = $headers;
-        $this->body = null === $body ? new Stream() : $body;
+        $this->body = $body ?? new Stream();
     }
 
-    public function getProtocolVersion()
+    public function getProtocolVersion(): string
     {
         return $this->version;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withProtocolVersion($version)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getHeaders()
+    public function getHeaders(): array
     {
         return $this->headers;
     }
 
-    public function hasHeader($name)
+    public function hasHeader($name): bool
     {
         return isset($this->headers[$name]);
     }
 
-    public function getHeader($name)
+    public function getHeader($name): array
     {
         return $this->hasHeader($name) ? $this->headers[$name] : [];
     }
 
-    public function getHeaderLine($name)
+    public function getHeaderLine($name): string
     {
         return $this->hasHeader($name) ? implode(',', $this->headers[$name]) : '';
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withHeader($name, $value)
     {
         $this->headers[$name] = (array) $value;
 
         return $this;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withAddedHeader($name, $value)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withoutHeader($name)
     {
         unset($this->headers[$name]);
 
         return $this;
     }
 
-    public function getBody()
+    public function getBody(): StreamInterface
     {
         return $this->body;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withBody(StreamInterface $body)
     {
         throw new \BadMethodCallException('Not implemented.');

Tests/Fixtures/Response.php

@@ -28,17 +28,20 @@ public function __construct($version = '1.1', array $headers = [], StreamInterfa
         $this->statusCode = $statusCode;
     }
 
-    public function getStatusCode()
+    public function getStatusCode(): int
     {
         return $this->statusCode;
     }
 
+    /**
+     * @return static
+     */
     public function withStatus($code, $reasonPhrase = '')
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getReasonPhrase()
+    public function getReasonPhrase(): string
     {
         throw new \BadMethodCallException('Not implemented.');
     }

Tests/Fixtures/ServerRequest.php

@@ -45,95 +45,156 @@ public function __construct($version = '1.1', array $headers = [], StreamInterfa
         $this->attributes = $attributes;
     }
 
-    public function getRequestTarget()
+    public function getRequestTarget(): string
     {
         return $this->requestTarget;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withRequestTarget($requestTarget)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getMethod()
+    public function getMethod(): string
     {
         return $this->method;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withMethod($method)
     {
+        throw new \BadMethodCallException('Not implemented.');
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return UriInterface
+     */
     public function getUri()
     {
         return $this->uri;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withUri(UriInterface $uri, $preserveHost = false)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getServerParams()
+    public function getServerParams(): array
     {
         return $this->server;
     }
 
-    public function getCookieParams()
+    public function getCookieParams(): array
     {
         return $this->cookies;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withCookieParams(array $cookies)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getQueryParams()
+    public function getQueryParams(): array
     {
         return $this->query;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withQueryParams(array $query)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getUploadedFiles()
+    public function getUploadedFiles(): array
     {
         return $this->uploadedFiles;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withUploadedFiles(array $uploadedFiles)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return array|object|null
+     */
     public function getParsedBody()
     {
         return $this->data;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withParsedBody($data)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
-    public function getAttributes()
+    public function getAttributes(): array
     {
         return $this->attributes;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return mixed
+     */
     public function getAttribute($name, $default = null)
     {
-        return isset($this->attributes[$name]) ? $this->attributes[$name] : $default;
+        return $this->attributes[$name] ?? $default;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withAttribute($name, $value)
     {
         throw new \BadMethodCallException('Not implemented.');
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return static
+     */
     public function withoutAttribute($name)
     {
         throw new \BadMethodCallException('Not implemented.');

Tests/Fixtures/Stream.php

@@ -26,12 +26,12 @@ public function __construct($stringContent = '')
         $this->stringContent = $stringContent;
     }
 
-    public function __toString()
+    public function __toString(): string
     {
         return $this->stringContent;
     }
 
-    public function close()
+    public function close(): void
     {
     }
 
@@ -40,61 +40,69 @@ public function detach()
         return fopen('data://text/plain,'.$this->stringContent, 'r');
     }
 
-    public function getSize()
+    public function getSize(): ?int
     {
+        return null;
     }
 
-    public function tell()
+    public function tell(): int
     {
         return 0;
     }
 
-    public function eof()
+    public function eof(): bool
     {
         return $this->eof;
     }
 
-    public function isSeekable()
+    public function isSeekable(): bool
     {
         return true;
     }
 
-    public function seek($offset, $whence = \SEEK_SET)
+    public function seek($offset, $whence = \SEEK_SET): void
     {
     }
 
-    public function rewind()
+    public function rewind(): void
     {
         $this->eof = false;
     }
 
-    public function isWritable()
+    public function isWritable(): bool
     {
         return false;
     }
 
-    public function write($string)
+    public function write($string): int
     {
+        return \strlen($string);
     }
 
-    public function isReadable()
+    public function isReadable(): bool
     {
         return true;
     }
 
-    public function read($length)
+    public function read($length): string
     {
         $this->eof = true;
 
         return $this->stringContent;
     }
 
-    public function getContents()
+    public function getContents(): string
     {
         return $this->stringContent;
     }
 
+    /**
+     * {@inheritdoc}
+     *
+     * @return mixed
+     */
     public function getMetadata($key = null)
     {
+        return null;
     }
 }