Skip to content

[Routing] document UriSigner::verify() #20905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

[Routing] document UriSigner::verify() #20905

merged 1 commit into from
Apr 21, 2025

Conversation

kbond
Copy link
Member

@kbond kbond commented Apr 18, 2025

Closes #20904

@carsonbot carsonbot added this to the 7.3 milestone Apr 18, 2025
OskarStark
OskarStark approved these changes Apr 19, 2025
View reviewed changes
@kbond kbond force-pushed the uri-signer-verify branch from 25671e7 to 9c4aee1 Compare April 19, 2025 12:55
wouterj
wouterj reviewed Apr 19, 2025
View reviewed changes
@kbond kbond force-pushed the uri-signer-verify branch from 9c4aee1 to aa3b167 Compare April 19, 2025 13:30
wouterj
wouterj approved these changes Apr 19, 2025
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like technique to use multiple catch statements to document the different exceptions!

@OskarStark
Copy link
Contributor

Thank you Kevin.

@OskarStark OskarStark merged commit ff88904 into symfony:7.3 Apr 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

[HttpFoundation] Add UriSigner::verify() that throws named exceptions
4 participants
@kbond @OskarStark @wouterj @carsonbot