[Turbo] Pass turbo_stream_listen
topics to mercure if not defined
#2694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation says:
"If you're using a private hub, you can add { withCredentials: true } as the third argument to turbo_stream_listen() to authenticate with the hub."
However, this doesn’t actually work because the cookie is not created.
See: MercureExtension.php#L75
To make it work, we need to explicitly specify the topics again. The working call looks like this:
turbo_stream_listen("topics", "default", { subscribe: 'topics', withCredentials: true }
So I updated the implementation, adding the
subscribe
key if it's not already defined.My mistake, sorry 😅