Skip to content

[Toolkit][Shadcn] Align typography with shadcn reference - #3588

Closed
seb-jean wants to merge 2 commits into
symfony:3.xfrom
seb-jean:feat/toolkit-shadcn-typography
Closed

seb-jean wants to merge 2 commits into
symfony:3.xfrom
seb-jean:feat/toolkit-shadcn-typography

Conversation

@seb-jean

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? yes
Issues Part of #3233
License MIT

@seb-jean
seb-jean requested a review from Kocal as a code owner May 22, 2026 16:28
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed Documentation Improvements or additions to documentation Toolkit labels May 22, 2026
@seb-jean
seb-jean force-pushed the feat/toolkit-shadcn-typography branch 2 times, most recently from c1a3840 to d4b8fdb Compare May 22, 2026 17:16

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is an issue here and with some other examples, why do we have H1, H2, H3 ... components, if we do not use them in the examples?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In React, Typography in shadcn/ui isn't actually a component.
There's nothing to install, no button.tsx, no npx shadcn add typography, no import. The docs page just gives you a catalog of Tailwind utility classes to copy directly onto plain HTML tags.

That's exactly why shadcn says "We do not ship any typography styles by default." Unlike Button (a real file with variants and an API) Typography is just a set of class recipes you apply by hand.

There are no components to create here, just examples.
The page needs to be reviewed.

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels May 27, 2026
Comment thread src/Toolkit/CHANGELOG.md Outdated
@seb-jean
seb-jean force-pushed the feat/toolkit-shadcn-typography branch from d4b8fdb to a9e14eb Compare June 6, 2026 17:08
@carsonbot carsonbot added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Jun 6, 2026
@seb-jean
seb-jean force-pushed the feat/toolkit-shadcn-typography branch 2 times, most recently from d0ceaf9 to 7355a92 Compare June 6, 2026 17:24
@seb-jean

seb-jean commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

I made the corrections and no files appear in templates/components/ anymore - Typography is not an installable component, it's just a collection of Tailwind utility class examples, unlike other components that ship actual templates.

@seb-jean
seb-jean force-pushed the feat/toolkit-shadcn-typography branch 2 times, most recently from 3995ff7 to c8cff1e Compare July 10, 2026 21:02
@seb-jean
seb-jean force-pushed the feat/toolkit-shadcn-typography branch from c8cff1e to a4845d1 Compare July 10, 2026 21:07
@Kocal

Kocal commented Aug 23, 2026

Copy link
Copy Markdown
Member

Hey!

By curiosity I just checked https://ui.shadcn.com/docs/components/base/typography but it redirects to https://ui.shadcn.com/docs/typeset.

Given this, and following #3588 (comment), I think the best thing to do here is to remove this recipe, I feel like there's no point in keeping it, at least not in this condition.

I'm closing this PR and will re-open a new one to remove the recipe.

Thanks anyway!

@Kocal Kocal closed this Aug 23, 2026
Kocal added a commit that referenced this pull request Aug 23, 2026
This PR was merged into the 3.x branch.

Discussion
----------

[Toolkit][Shadcn] Remove typography recipe

| Q              | A
| -------------- | ---
| Bug fix?       | no
| New feature?   | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations?  | no <!-- if yes, also update UPGRADE-*.md and src/**/CHANGELOG.md -->
| Documentation? | no <!-- required for new features, or documentation updates -->
| Issues         | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License        | MIT

Following #3588 (comment)

Commits
-------

3ce2965 [Toolkit][Shadcn] Remove typography recipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Status: Needs Review Needs to be reviewed Toolkit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants