[Toolkit] Add lint kit command and CI lint workflow - #3655
Merged
Merged
Conversation
Kocal
force-pushed
the
toolkit-add-lint-command
branch
4 times, most recently
from
June 4, 2026 14:01
5f1bc04 to
763472e
Compare
Contributor
|
This lint kit command is great, thank you. Would it be difficult to add an option to fix errors? |
Member
Author
|
(warnings found in the two jobs will be fixed in another PR)
That's a good question, it's surely possible, maybe in a next iteration, if identified errors could be automatically fixed. |
Kocal
force-pushed
the
toolkit-add-lint-command
branch
from
June 4, 2026 20:05
654736b to
e4a899a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a quality-control layer for Toolkit kits, so structural and dependency-coherence regressions are caught before they ship.
A new
ux:toolkit:lint-kit <kit-path>command runs a pipeline of small checkers against a kit and reports issues per recipe.The command is exposed as a standalone
bin/ux-toolkit-kit-lintonly, no DI wiring, since it has no value inside a user's app: it's a tool for kit maintainers, used locally or from CI.Checks performed:
dependencies.recipe[](errors);dependencies.npm/.importmap, and a curated mapping between Composer packages and the Twig symbols they provide.A dedicated GitHub Actions workflow runs the linter on every kit under
src/Toolkit/kits/*via a dynamically built matrix, triggered only whensrc/Toolkit/**changes.Each kit gets its own job (
fail-fast: false) so output stays readable and failures are isolated; adding a new kit needs no workflow change.