[LiveComponent] Fix proxy turning "toJSON" and "then" protocol probes into server actions - #3791
Merged
Merged
Conversation
carsonbot
added
Bug
Contributor
📊 Packages dist files size differenceℹ️ No difference in dist packagesFiles. |
Member
|
Please target 3.x branch |
Amoifr
force-pushed
the
fix-3752-proxy-protocol-probes
branch
from
August 20, 2026 13:36
0d97fae to
80d3c5f
Compare
Contributor
Author
|
Done! Rebased onto 3.x, dist rebuilt from the 3.x sources, JS suite green (297 tests), base switched. |
Member
|
Dist files must be rebuild |
Contributor
Author
|
Rebuilt the dist with the current toolchain (Node 22 + pnpm, same as the |
Kocal
force-pushed
the
fix-3752-proxy-protocol-probes
branch
from
August 21, 2026 12:58
c347f16 to
d0f3f8b
Compare
Member
|
I just added a small note in the documentation, merging when it's green |
Kocal
approved these changes
Aug 21, 2026
carsonbot
added
Status: Reviewed
… into server actions
Kocal
force-pushed
the
fix-3752-proxy-protocol-probes
branch
from
August 21, 2026 13:07
d0f3f8b to
87621bf
Compare
Member
|
Thank you @Amoifr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component proxy treats any unknown property read as a server action.
JSON.stringify()probestoJSON, and promise assimilation (e.g.await component, or returning the proxy from an async function) probesthen: both received a callable and invoked it, queueing a phantom server action namedtoJSONorthen.This PR returns
undefinedfor these two protocol probes. The guard sits after the model lookup, so a model actually namedtoJSONorthenkeeps priority; only the "unknown name = action" fallback is skipped. Same family of fix as #2537, which stoppedJSON.stringify()from serializing__component.Tests cover both probes (no action queued,
awaitresolves to the proxy itself) and the model-priority case.