[Toolkit] Restore the "available since" note on recipe install steps - #3860
Merged
Merged
Conversation
| Q | A | -------------- | --- | Bug fix? | yes | New feature? | no | Deprecations? | no | Documentation? | no | Issues | Fix symfony#3857 | License | MIT Reported in symfony#3857: a Toolkit recipe that's merged but not yet tagged shows up in the documentation with nothing to say it can't be installed yet, so running `php bin/console ux:install form` fails with `The recipe "form" does not exist in any official kit` and gives no clue why. The docs used to carry a note reading `Available since UX Toolkit X.Y.`, built from the `version-added` field each recipe manifest declares. It got lost when kit documentation became generic: the per-recipe template that held the note went away, and the `::: installation` directive that replaced it never carried it over. This restores it in `_installation.md.twig`, for both the plain Markdown output and the tabbed HTML one. The `login-01` and `login-02` blocks, both added after `v3.4.0`, had no `version-added` at all, so they'd have stayed silent even with the note restored; they now declare `3.5`. Nothing was holding the note in place before, which is how it disappeared without a test turning red, so there's now a test covering both output formats plus a recipe that declares no version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's back again