Skip to content

[StimulusBundle] Detect the standalone AssetMapper bundle - #3867

Open
smnandre wants to merge 12 commits into
symfony:3.xfrom
smnandre:sa/stimulus-asset-mapper-bundle
Open

smnandre wants to merge 12 commits into
symfony:3.xfrom
smnandre:sa/stimulus-asset-mapper-bundle

Conversation

@smnandre

@smnandre smnandre commented Sep 12, 2026

Copy link
Copy Markdown
Member
Q A
Bug fix? no
New feature? no
Deprecations? no
Documentation? no
Issues Fix #...
License MIT

Add support for the AssetMapper 8.2 new bundle (fix CI failures with 8.2 in the same time)

@Kocal Kocal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a bug-fix or a feature?

@smnandre

Copy link
Copy Markdown
Member Author

Dépends on how you look at it. As we test unreleased Symfony versions, the CI fails for something we do not support yet.

By supporting this change; this fix the CI fails.

No bug happen to anyone now, but will when/if people migrate to AssetMapper new bundle in 8.2

@Kocal

Kocal commented Sep 13, 2026

Copy link
Copy Markdown
Member

I would go for a feature, also can you please modify all the other packages relying on this logic?

Capture d’écran 2026-09-13 à 22 19 08

Thanks

Comment thread src/StimulusBundle/CHANGELOG.md Outdated

## 3.5.0

- Fix AssetMapper detection with Symfony 8.2's standalone `AssetMapperBundle`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go for:

Suggested change
- Fix AssetMapper detection with Symfony 8.2's standalone `AssetMapperBundle`
- Add support for AssetMapper 8.2+

@Kocal Kocal added the Feature New Feature label Sep 13, 2026
@smnandre
smnandre requested a review from Kocal September 14, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants