Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
markerrecipe to the Shadcn kit, porting Shadcn UI's Marker.Markerdisplays an inline status, system note, bordered row, or labeled separator in a conversation — it composes well with thebubblerecipe in a chat thread.Components
Three variants are available via the
variantprop:defaultborderseparatorThe root is polymorphic through the
asprop (upstream'sasChild), so a marker can render as a realaorbuttonwhen it is interactive.Marker:Iconis decorative and carriesaria-hidden="true", soMarker:Contentholds the accessible name. RTL is supported throughltr:/rtl:class variants.All upstream examples are ported as live-preview blocks in the recipe
README.md(Variants, Status, Shimmer, Separator, Border, With Icon, Links and Buttons), plus the usual RTL section.Notes for reviewers
shimmerutility class, which ships in theshadcnnpm package'stailwind.css(background-clip: textplus atw-shimmerkeyframe). The Toolkit ships no CSS, and Tailwind cannot declare keyframes in an arbitrary value, so the example uses the built-inanimate-pulseto convey the same in-progress cue. The README states this explicitly. Happy to drop the section instead if preferred.apps/v4/styles/radix-nova/ui/and itsui-rtl/counterpart no longer exist upstream — that directory is now gitignored and generated by the registry build. Canonical Tailwind classes were taken fromapps/v4/registry/new-york-v4/ui/marker.tsx(theregistry/bases/radixvariant only carriescn-markerCSS hooks). With noui-rtlfile left to diff, the RTL variants for the three directional classes (text-left,before:mr-1,after:ml-1) were derived by hand following the kit's existingltr:<physical> rtl:<logical>idiom.lucide:file-text,lucide:book-open-checkandlucide:rotate-ccwwere added totests/Fixtures/icons/lucide/for the examples.bin/ux-toolkit-kit-lint --fail-on-warning kits/shadcnandtwig-cs-fixerare clean.A companion PR on
symfony/ux.symfony.comwill follow to rebuild the Tailwind CSS — the recipe introduces classes new to the kit (group/marker,min-h-4,before:flex-1,before:bg-border,rtl:before:me-1,rtl:after:ms-1). No Stimulus controller is shipped.