♻ — Use a more modern way of installing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldidry
force-pushed
the
update-Makefile.PL
branch
from
9d3eb5e to
68b666d
Compare
|
Yes, definitely a big step for sanitizing Mhonarc installation 👍 |
ldidry
force-pushed
the
update-Makefile.PL
branch
from
68b666d to
550224e
Compare
dverdin
reviewed
Jul 20, 2020
There was a problem hiding this comment.
Honestly, the only thing I ever developed instllation for in Perl was Sympa. So it's difficult for me to give you advice on this.
However, I checked your branch out and it install perfectly using the standard Perl command :
perl Makefile.PL
make
make test
make install
So as far as I know, you Pr is perfectly correct!
- modern Makefile.PL - centralization of version number: just update it in lib/MHonArc.pm
ldidry
force-pushed
the
update-Makefile.PL
branch
from
550224e to
7329e9e
Compare
ikedas
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/MHonArc.pm=> will fail until 🐛 — Fix deprecation warnings #2 is merged(🐛 — Fix deprecation warnings #2 is merged, CI works now)I’m not sure that I used the better way to centralize the version number. Feel free to comment and propose a better way to do that.