Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Remove bad code #6

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+344 −17
Open

🔥 Remove bad code #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
124b0a9
🔥 — Remove useless / bad practice code
ldidry Jul 16, 2020
35ab4fe
Adding `use strict; use warnings` everywhere
ldidry Jul 16, 2020
b7ba8aa
Merge branch 'develop' into remove-bad-code
ikedas Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/mha-preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ my $PreviewLen = 256;
##-----------------------------------------------------------------------##

MAIN: {
unshift(@INC, 'lib'); # Should I leave this line in?

## Grab options from @ARGV unique to this program
my %opts = ();
Getopt::Long::Configure('pass_through');
Expand Down
3 changes: 3 additions & 0 deletions lib/MHonArc/Char.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@

package MHonArc::Char;

use strict;
use warnings;

our $VERSION = '2.6.24';

###############################################################################
Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/Char/JP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

package MHonArc::Char::JP;

use strict;
use warnings;
our $VERSION = '2.6.24';

sub jp_2022_to_euc {
Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/Char/KR.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@

package MHonArc::Char::KR;

use strict;
use warnings;
our $VERSION = '2.6.24';

sub kr_2022_to_euc {
Expand Down
1 change: 1 addition & 0 deletions lib/MHonArc/CharEnt.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
package MHonArc::CharEnt;

use strict;
use warnings;
use MHonArc::CharMaps;
use MHonArc::Char;

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleArabic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleArabic;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, Github have some troubles with the characters in some files 🤷

If you checkout my branch and do git diff a98d78e..e4b5f4a, it should be displayed correctly (here, the first line is package MHonArc::UTF8::AppleArabic;), except for characters that you don't have the font to display.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways we may let homemade codecs retire: Encode module became standard way as of Perl 5.8. I'd like to work for this improvement in some day.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikedas sounds good 👍

use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleCenteuro.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleCenteuro;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleCroatian.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleCroatian;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleCyrillic.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleCyrillic;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleGreek.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleGreek;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleHebrew.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleHebrew;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleIceland.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleIceland;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleRoman.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleRoman;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleRomanian.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleRomanian;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleThai.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleThai;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/AppleTurkish.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::AppleTurkish;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/BIG5_ETEN.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::BIG5_ETEN;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/BIG5_HKSCS.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::BIG5_HKSCS;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1250.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1250;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1251.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1251;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1252.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1252;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1253.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1253;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1254.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1254;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1255.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1255;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1256.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1256;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1257.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1257;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP1258.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP1258;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP866.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP866;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP932.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP932;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP936.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP936;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP949.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP949;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/CP950.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::CP950;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/EUC_JP.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::EUC_JP;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/GB2312.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::GB2312;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/GOST19768_87.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::GOST19768_87;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/HP_ROMAN8.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::HP_ROMAN8;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_1.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_1;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_10.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_10;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_11.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_11;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_13.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_13;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_14.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_14;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_15.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_15;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_16.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_16;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_2.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_2;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_3.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_3;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_4.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_4;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_5.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_5;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_6.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_6;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_7.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_7;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_8.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_8;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/ISO8859_9.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::ISO8859_9;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/KOI8_A.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::KOI8_A;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/KOI8_B.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::KOI8_B;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/KOI8_E.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::KOI8_E;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
2 changes: 2 additions & 0 deletions lib/MHonArc/CharEnt/KOI8_F.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
package MHonArc::CharEnt::KOI8_F;
use strict;
use warnings;

our $VERSION = '2.6.24';

Expand Down
Loading