Sceneri title changes#365
Draft
taggart wants to merge 8 commits into
Draft
Conversation
get rid of confusing send.editorkeyonlyauth which didn't do anything create send.editorkeyauth type clarify text
send.publickey is weird, it does a request_auth for all smtp, but the user authenticating wouldn't need to be a subscriber/editor/owner/ listmaster, so would just need an account on the server? OR have DKIM This doesn't seem that useful, but if it is it should probably be named send.publicauthdkim or something
Member
Contributor
|
Why don't you have #179 into account? In my institution we ended by renaming scenari files with numeral prefixes. For example, the add menu now shows these scenarios in this order: But if you rename the scenari files from public to restricted you will get something like: This makes life easier for users to select the correct scenario since now they know the scenarios proposed in the drop-down menus have a logical order. And furthermore, an exercise like this will allow you to identify scenarios that are useless or are equal (for example, Best regards, |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a collection of scenari related stuff, mostly title.gettext changes to make things more consistent. There are a couple changes that could be considered related to #362 where an authenticated version of a type didn't exist. In those cases the patch adds one, but maybe it would be better to add the authentication to the existing non-auth version?
Feel free to just cherry pick whatever makes sense and also let me know if you'd prefer that I break things up into multiple PRs.