Fix: Ensure PdfForm is returned even when acroForm has no fields #2333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue in the
PdfDocument.form
getter where the form would not be returned if theacroForm
existed in the catalog but contained no fields (fields.count == 0
).As a result,
_form
would remainnull
, leading to inconsistent behavior or potentialnull
access elsewhere in the code.What was changed
if (_form!.fields.count != 0)
condition._form
is always returned once initialized, regardless of the number of fields.Why is this needed?
In some PDF documents, the
acroForm
dictionary exists but does not yet have any form fields (e.g., newly created or partially filled forms). Without this fix, attempting to accessform
would result in anull
, which may cause exceptions or unexpected behavior in consumer code.How to test
acroForm
dictionary.document.form
and ensure it returns a validPdfForm
instance, notnull
.