Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ldk to 0.0.125 #2514

Merged
merged 5 commits into from
Mar 10, 2025
Merged

feat: update ldk to 0.0.125 #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4888291
feat: update ldk to 0.0.125
Jasonvdb Mar 7, 2025
ade831d
chore: update Podfile.lock
pwltr Mar 7, 2025
1a39acd
fix: pod lockfile update
Jasonvdb Mar 7, 2025
0e3b66a
fix: update rn-ldk for architecture fix
Jasonvdb Mar 10, 2025
3d47edb
chore: remove patch
pwltr Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions __tests__/lightning.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,15 @@ describe('getFees', () => {
const result = await getFees();

expect(result).toEqual({
onChainSweep: 111,
maxAllowedNonAnchorChannelRemoteFee: Math.max(25, 111 * 10),
minAllowedAnchorChannelRemoteFee: 108,
minAllowedNonAnchorChannelRemoteFee: 107,
anchorChannelFee: 109,
nonAnchorChannelFee: 110,
channelCloseMinimum: 108,
outputSpendingFee: 111,
maximumFeeEstimate: 111,
urgentOnChainSweep: 111,
});
expect(fetch).toHaveBeenCalledTimes(2);
expect(fetch).toHaveBeenCalledWith(MEMPOOL_URL);
Expand All @@ -79,14 +80,15 @@ describe('getFees', () => {

const result = await getFees();
expect(result).toEqual({
onChainSweep: 999,
maxAllowedNonAnchorChannelRemoteFee: Math.max(25, 999 * 10),
minAllowedAnchorChannelRemoteFee: 997,
minAllowedNonAnchorChannelRemoteFee: 996,
anchorChannelFee: 997,
nonAnchorChannelFee: 998,
channelCloseMinimum: 997,
outputSpendingFee: 999,
maximumFeeEstimate: 999,
urgentOnChainSweep: 999,
});
expect(fetch).toHaveBeenCalledTimes(3);
});
Expand All @@ -110,7 +112,7 @@ describe('getFees', () => {
});

const result = await getFees();
expect(result.onChainSweep).toBe(111);
expect(result.urgentOnChainSweep).toBe(111);
expect(fetch).toHaveBeenCalledTimes(4);
expect(fetch).toHaveBeenCalledWith(MEMPOOL_URL);
expect(fetch).toHaveBeenCalledWith(BLOCKTANK_URL);
Expand Down Expand Up @@ -146,7 +148,7 @@ describe('getFees', () => {
});

const result = await getFees();
expect(result.onChainSweep).toBe(999);
expect(result.urgentOnChainSweep).toBe(999);
});

it('should handle invalid blocktank response', async () => {
Expand All @@ -167,7 +169,7 @@ describe('getFees', () => {
});

const result = await getFees();
expect(result.onChainSweep).toBe(111);
expect(result.urgentOnChainSweep).toBe(111);
});

it('should handle timeout errors gracefully', async () => {
Expand Down
4 changes: 2 additions & 2 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ PODS:
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- react-native-ldk (0.0.155):
- react-native-ldk (0.0.158):
- React
- react-native-mmkv (2.12.2):
- DoubleConversion
Expand Down Expand Up @@ -2405,7 +2405,7 @@ SPEC CHECKSUMS:
react-native-biometrics: 43ed5b828646a7862dbc7945556446be00798e7d
react-native-blur: b06c3fe88680beac622d8d13b8c36ec15c50383b
react-native-image-picker: 037a6ccde76aa165446e1eaeb8866cb00f461916
react-native-ldk: 6f12cfcabb910cb88478768d02d7345775289c21
react-native-ldk: 2b77f83c7ca5809d1221288dfc4ee9ffef13f1a3
react-native-mmkv: a6e08ad1b51b84af075f91798f8a92c878472265
react-native-netinfo: cec9c4e86083cb5b6aba0e0711f563e2fbbff187
react-native-pubky: 54d37810f35d9da11f8c199a6036e5729081951b
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@reduxjs/toolkit": "2.2.6",
"@shopify/react-native-skia": "next",
"@synonymdev/blocktank-lsp-http-client": "2.2.0",
"@synonymdev/react-native-ldk": "0.0.155",
"@synonymdev/react-native-ldk": "0.0.158",
"@synonymdev/react-native-lnurl": "0.0.10",
"@synonymdev/react-native-pubky": "^0.3.0",
"@synonymdev/result": "0.0.2",
Expand Down
62 changes: 0 additions & 62 deletions patches/@synonymdev+react-native-ldk+0.0.155.patch
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion src/utils/lightning/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,14 +348,15 @@ export const getFees: TGetFees = async () => {

return {
//https://github.com/lightningdevkit/rust-lightning/blob/main/CHANGELOG.md#api-updates
onChainSweep: fees.fast,
maxAllowedNonAnchorChannelRemoteFee: Math.max(25, fees.fast * 10),
minAllowedAnchorChannelRemoteFee: fees.minimum,
minAllowedNonAnchorChannelRemoteFee: Math.max(fees.minimum - 1, 0),
anchorChannelFee: fees.slow,
nonAnchorChannelFee: fees.normal,
channelCloseMinimum: fees.minimum,
outputSpendingFee: fees.fast,
maximumFeeEstimate: fees.fast,
urgentOnChainSweep: fees.fast,
};
};

Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4585,16 +4585,16 @@ __metadata:
languageName: node
linkType: hard

"@synonymdev/react-native-ldk@npm:0.0.155":
version: 0.0.155
resolution: "@synonymdev/react-native-ldk@npm:0.0.155"
"@synonymdev/react-native-ldk@npm:0.0.158":
version: 0.0.158
resolution: "@synonymdev/react-native-ldk@npm:0.0.158"
dependencies:
"@synonymdev/raw-transaction-decoder": 1.1.0
bech32: ^2.0.0
bitcoinjs-lib: ^6.0.2
peerDependencies:
react-native: "*"
checksum: a5dc76dcb138d0b293a24759415988a277c7226bb8631b3cf87fd0d961330f795dcf5c6bac2277744a7dd034303bd74e9d682a0689c9c03181e3060ff7053399
checksum: e93fccadea4def04e9b1232070af0019ebfc0996cee1595738e83b8d9e3e00a64491b5366116a57f65b053732efe6903ff8df61c9fe4c5891f82bf17abaefed5
languageName: node
linkType: hard

Expand Down Expand Up @@ -5826,7 +5826,7 @@ __metadata:
"@reduxjs/toolkit": 2.2.6
"@shopify/react-native-skia": next
"@synonymdev/blocktank-lsp-http-client": 2.2.0
"@synonymdev/react-native-ldk": 0.0.155
"@synonymdev/react-native-ldk": 0.0.158
"@synonymdev/react-native-lnurl": 0.0.10
"@synonymdev/react-native-pubky": ^0.3.0
"@synonymdev/result": 0.0.2
Expand Down