Fix jagged GFM table round-trip by not padding short rows - #10
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
markdown-table always emits a rectangle. After stringify+parse, short body rows gained empty cells. Strip padded cells so AST widths survive.
|
Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source): I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done! Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
package.jsonfor relevant changes (versions, scripts, etc)Description of changes
Parsing a GFM table with short body rows, then stringifying and re-parsing, padded those rows to the header width.
markdown-tablealways emits a rectangle, so a later parse saw extra empty cells and the AST drifted.After
markdown-tableruns, drop the padded cells so stringify keeps each row’s real cell count. Header and delimiter rows stay at header width. Tests cover the issue fixtures (a||/||/||||||) plus a jagged aligned table and escaped pipes in cells.Fixes #8.