Skip to content

🌱 Allow reattach on node with different name.#2

Open
guettli wants to merge 2 commits intomainfrom
tg/allow-reattach-on-node-with-different-name
Open

🌱 Allow reattach on node with different name.#2
guettli wants to merge 2 commits intomainfrom
tg/allow-reattach-on-node-with-different-name

Conversation

@guettli
Copy link

@guettli guettli commented Apr 22, 2024

Changed Go code and values.yaml, so that the code runs in a wl-cluster (baremetal on hetzner).

This .envrc is needed:

❯ cat .envrc 
export KUBECONFIG=$HOME/syself/cluster-stacks/wl.kubeconfig
export PUSH=true
export IMAGE_PREFIX=ghcr.io/syself/csi-

Install with:

helm install --namespace=topolvm-system topolvm charts/topolvm

You can upload a new image with make multi-platform-image-normal

@guettli guettli requested a review from janiskemper April 24, 2024 22:09
## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
nodeSelector: {}
nodeSelector:
instance.hetzner.cloud/is-root-server: "true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you can remove this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batistein I don't think this can be removed. Up to now we don't have a way to specifiy nodes which have storage.

## ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/
nodeSelector: {}
nodeSelector:
instance.hetzner.cloud/is-root-server: "true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

@guettli guettli force-pushed the tg/allow-reattach-on-node-with-different-name branch from df1205a to d767320 Compare April 25, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants