S3 destination: new options #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odmehbb
approved these changes
May 29, 2025
therandomstring
requested changes
May 29, 2025
| ## content-type() | ||
|
|
||
| |Type:| string| | ||
| |Default:| | |
There was a problem hiding this comment.
The default content type is application/octet-stream
There was a problem hiding this comment.
Fixed in latest commit.
|
|
||
| *Description:* This option allows the user to change the displayed content type of the log messages. | ||
|
|
||
| ### Example: content-type() applied in an S3 destination |
There was a problem hiding this comment.
I don't think the example is necessary here, but I can be convinced otherwise
There was a problem hiding this comment.
Fixed in latest commit.
There was a problem hiding this comment.
Could you please squash said commit?
Signed-off-by: Zsolt Gyulai (zgyulai) <[email protected]> Removed example, and added default value to content_type() Signed-off-by: Zsolt Gyulai (zgyulai) <[email protected]>
zsoltgyulai94
force-pushed
the
doc-s3-updates
branch
from
1b27f06 to
6867f6d
Compare
therandomstring
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new options for amazon s3 destination: