Fix directory monitor path chaos #5317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at cannot be split as it is an event handler callback) Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
… is set before trying to call it Signed-off-by: Hofi <[email protected]>
…obs if its new notified member set to TRUE This can be used whereas a PollEvents object is required and cannot be NULL, but its functionality is not needed at all, e.g in the file_reader, where the watched file modification events can be detected and delivered in other ways. Far not the best solution, but PollEvents is too deeply integrated currently, and I did not want to do an even bigger refactor. Signed-off-by: Hofi <[email protected]>
…we do it for the directory monitor Signed-off-by: Hofi <[email protected]>
… using the poll_events provided ones Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
…on events Signed-off-by: Hofi <[email protected]>
…ot use poll_events Signed-off-by: Hofi <[email protected]>
…he reader Signed-off-by: Hofi <[email protected]>
…le to display the real_path in the starting log message Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
Signed-off-by: Hofi <[email protected]>
… it everywhere instad Signed-off-by: Hofi <[email protected]>
…y and remove FIXMEs Signed-off-by: Hofi <[email protected]>
HofiOne
force-pushed
the
fix-directory-monitor-path-chaos
branch
from
b198c9c to
68dea55
Compare
This was referenced Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using now the full path everywhere
Depends on #5315
Signed-off-by: Hofi [email protected]