Pack gap bit into size field's LSB#26
Open
devarajabc wants to merge 1 commit intosysprog21:masterfrom
Open
Conversation
Reduce `ringbuf_element_t` from 8 bytes to 4 bytes by encoding the "gap" flag into the LSB of the size field. Since all payload sizes are padded to 8 bytes, the lower 3 bits of size are always zero, making it safe to reuse bit 0. This shrinks the per-element header.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
devarajabc
changed the title
jserv
reviewed
Oct 1, 2025
Comment on lines
+13
to
+16
| #define RINGBUF_PAD(SIZE) \ | ||
| (((size_t) (SIZE) + 7U) & (~7U)) /* size is padded to a multiple of 8 */ | ||
| #define GAP_MASK 1U | ||
| #define SIZE_MASK (~GAP_MASK) |
jserv
requested changes
Oct 1, 2025
Contributor
jserv
left a comment
jserv
left a comment
There was a problem hiding this comment.
Show the real benefits via benchmarking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce
ringbuf_element_tfrom 8 bytes to 4 bytes by encoding thegapflag into the LSB of the size field.Since all payload sizes are padded to 8 bytes, the lower 3 bits of size are always zero, making it safe to reuse bit 0.
This shrinks the per-element header.
Summary by cubic
Packed the gap flag into the size field’s LSB, shrinking ringbuf_element_t from 8 bytes to 4 bytes. This reduces per-element overhead and can improve cache locality.
Refactors
Migration