Tp taiwan dylan #54
Open
Tp taiwan dylan #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b3acf69.
Google Chart, multiple-choice category fliter, Email-Notification, Hide-Show button, Message Details, Group, Hide-Report, Send-Mail and Tphp file for connect mobile.
Google Chart, multiple-choice category fliter, Email-Notification, Hide-Show button, Message Details, Group, Hide-Report, Send-Mail and Tphp file for connect mobile.
|
In terms of the files present this looks much more sane now. However all those unnecessary files are still present in the Git history. You need to squash this into a single commit. What we would much prefer however is having the proper history of the SVN repository converted via e.g. svn2git as I mentioned in #53. Please also change the title of the pull request and provide a detailed description of the changes. |
|
Relevant context: http://taarifa.wordpress.com/2014/07/11/open-source-values/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduction the pull request .