fix: remove vizHeight and vizWidth from ImageRequestOptions #1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorwoods
force-pushed
the
jorwoods/image_no_hw
branch
from
f9395cb to
0fa709d
Compare
|
This functionality was added in the server API version 3.23. Instead of removing these options, need to throw an error that the API version is too low and doesn't support it. |
Many filters and RequestOptions added in 3.23. Adds explicit support for them and checks for prior versions.
jorwoods
force-pushed
the
jorwoods/image_no_hw
branch
from
0fa709d to
1b6763f
Compare
|
Regarding #1564, TSC was passing query parameters to the server, and the server was quietly ignoring them because those attributes were not yet supported. This PR contains checks to explicitly compare the server version and the parameters being passed to ensure they are supported. |
renoyjohnm
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1564
Retrieving a view image does not support vizHeight and vizWidth serverside. Supporting it for images as well was a mistake.