@W-19426562: Don't provide rowLimit option to VDS before 2026.1#214
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): DevPlat Heroku <d***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
There was a problem hiding this comment.
Pull request overview
Updates query-datasource to avoid sending the rowLimit option to VizQL Data Service (VDS) on Tableau versions prior to 2026.1.0, per the linked customer report.
Changes:
- Version-gate the
optionspassed to VDS sorowLimitis only included for Tableau2026.1.0+. - Bump npm package version from
1.14.4to1.14.5. - Update
package-lock.jsonto match the new package version.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/tools/queryDatasource/queryDatasource.ts |
Uses getResultForTableauVersion to conditionally include rowLimit only on 2026.1.0+. |
package.json |
Version bump to 1.14.5. |
package-lock.json |
Lockfile version sync to 1.14.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
anyoung-tableau
force-pushed
the
anyoung/rowLimit
branch
from
de10b4c to
006d9a0
Compare
…eau#214) * Don't provide rowLimit to VDS before 2026.1 * Bump * Fix tests
Customer report here: https://salesforce-internal.slack.com/archives/C08QYBH8AE5/p1770197628514829
Fixes #215