feat(desktop): control start page visibility - #884
Merged
Conversation
11 tasks
…art-page-tools # Conflicts: # package-lock.json # package.json
mattcfilbert
approved these changes
Sep 11, 2026
mattcfilbert
left a comment
mattcfilbert
left a comment
Contributor
There was a problem hiding this comment.
MattGPT — Andy-lens review: no P0/P1 findings. Approving with one P2 test-count correction noted inline. Validation: 185 targeted tests passed and the count assertion failed; lint and typechecking passed. Live Desktop checks were not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
This establishes a rule we now keep: typed Desktop UI-state actions are exposed as idempotent MCP tools and report Desktop's actual resulting state.
Description
set-start-page-visibilityfor explicitly showing or hiding Tableau Desktop's start page.2.68.4.Motivation and Context
Agents can read start-page visibility through app info but cannot currently request a desired state through a dedicated MCP tool. The new tool makes that operation explicit and avoids non-idempotent toggle behavior.
Type of Change
How Has This Been Tested?
Verification
npx --no-install vitest run --config ./vitest.config.ts --maxWorkers=2 src/desktop/externalApi/externalApiHttp.test.ts src/desktop/externalApi/externalApiHttpAsyncDispatch.test.ts src/desktop/externalApi/externalApiToolExecutor.test.ts src/tools/desktop/api/setStartPageVisibility.test.ts src/server.desktop.test.ts src/tools/toolName.test.tsAGENT_CHECK_MAX_WORKERS=2 scripts/agent-checkRelated Issues
Checklist
npm run version. For example,use
npm run version:patchfor a patch version bump.environment variable or changing its default value.
Contributor Agreement
By submitting this pull request, I confirm that:
its Contribution Checklist.